[Validator] fixed Boolean handling in XML constraint mappings #8831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the |
|
@bschussek fixed ;) |
| @@ -166,7 +166,7 @@ protected function parseOptions(\SimpleXMLElement $nodes) | |||
| $value = array(); | |||
| } | |||
| } else { | |||
| $value = trim($node); | |||
| $value = trim(XmlUtils::phpize($node)); | |||
There was a problem hiding this comment.
I think you should test whether the value is a string before applying trim(), otherwise values will be converted back to strings.
There was a problem hiding this comment.
Indeed, I was fooled by the usage of assertEquals. Everything should be ok now.
fabpot
added a commit
that referenced
this pull request
Aug 24, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [Validator] fixed Boolean handling in XML constraint mappings | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #5603 | License | MIT | Doc PR | n/a ping @bschussek Commits ------- 33b0a17 [Validator] fixed Boolean handling in XML constraint mappings (closes #5603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @bschussek