[DependencyInjection] Test constants #8663
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 4, 2013 11:39
In order to make more readable future diffs, expected values have been indented. This means that if someone adds a new value at the end of the array, the diff will only print the new line with only the new addition, instead of of deletion of the whole array and addition with the whole array with the new value.
Added a test with a fixture for parameters with 'constant' as type.
Taking int account @fabpto's comments: * gnugat-forks@f9463da#commitcomment-3784007 * gnugat-forks@f9463da#commitcomment-3784010
| 'float' => 1.3, | ||
| 1000.3, | ||
| 'a string', | ||
| array('foo', 'bar',) |
There was a problem hiding this comment.
This is not what I had in mind. I was thinking about adding a comma at the end of the line: array('foo', 'bar'),
There was a problem hiding this comment.
Oh I see, I totally missed these two. I just fixed it, if it's alright with you I'll squash the last two commits into the first one. Or I could squash everything into one commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test for constant support in XML configuration files.
Related PR: #8661