[Router] added static requirement optimization to php matcher dumper #8497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $placeholder = sprintf('{%s}', $parameter); | ||
|
|
||
| if (preg_match('~^[\w]+$~i', $pattern) && false !== strpos($optimizedRoute->getPath(), $placeholder)) { | ||
| var_dump($parameter, $pattern); |
There was a problem hiding this comment.
@henrikbjorn oh, thanks... how could I miss it?!
| $dumper = new PhpMatcherDumper($collection); | ||
| $fixture = __DIR__.'/../../Fixtures/dumper/optimized_route_matcher.php'; | ||
|
|
||
| $this->assertEquals(file_get_contents($fixture), $dumper->dump()); |
There was a problem hiding this comment.
$this->assertStringEqualsFile($fixture, $dumper->dump());
There was a problem hiding this comment.
@stloyd wow, I was not aware of this method! I update the PR now, thanks.
|
@fabpot is this PR okay for you? |
|
Looks like a lot of additional code for a very slight benefit. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to apply #6838 suggestion.
@Tobion could you please take a look and tell me what you think?
This comment should be taken in account #6838 (comment), this optimization could be performed by the
RouteCompilerbut it would require #5410 to be fixed (which may never happen).