10000 Reverts recent change that added type coercion for JSON responses by svperfecta · Pull Request #8477 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Reverts recent change that added type coercion for JSON responses #8477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Reverts recent change that added type coercion for JSON responses #8477

wants to merge 1 commit into from

Conversation

svperfecta
Copy link

We shouldn't be coercing primitive in the array provided to setData.

Reverts JSON_NUMERIC_CHECK
02e6aef 
We shouldn't be coercing types.
@svperfecta
Copy link
Author

References #8420

@lyrixx
Copy link
Member
lyrixx commented Jul 11, 2013

More info:

php > echo json_encode(array('phone_number' => '0033123456789'), JSON_NUMERIC_CHECK);
{"phone_number":33123456789}
php > echo json_encode(array('phone_number' => '0033123456789'));
{"phone_number":"0033123456789"}

fabpot added a commit that referenced this pull request Jul 11, 2013
@fabpot
merged branch genexp/master (PR #8477)
d3f16d0 
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #8477).

Discussion
----------

Reverts recent change that added type coercion for JSON responses

We shouldn't be coercing primitive in the array provided to setData.

Commits
-------

02e6aef Reverts JSON_NUMERIC_CHECK
@fabpot fabpot closed this Jul 11, 2013
@lyrixx lyrixx mentioned this pull request Jul 11, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svperfecta @lyrixx @fabpot
0