8000 [Console] Fixed the table rendering with multi-byte strings. by jakzal · Pull Request #8285 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Fixed the table rendering with multi-byte strings. #8285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2013
Merged

[Console] Fixed the table rendering with multi-byte strings. #8285

merged 1 commit into from
Jun 16, 2013

Conversation

jakzal
Copy link
Contributor
@jakzal jakzal commented Jun 15, 2013
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #8284
License MIT
Doc PR -

fabpot added a commit that referenced this pull request Jun 16, 2013
@fabpot
merged branch jakzal/bugfix/table-helper-multi-byte (PR #8285)
0da84da 
This PR was merged into the 2.3 branch.

Discussion
----------

[Console] Fixed the table rendering with multi-byte strings.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8284
| License       | MIT
| Doc PR        | -

Commits
-------

ab1439e [Console] Fixed the table rendering with multi-byte strings.
@fabpot fabpot merged commit ab1439e into symfony:2.3 Jun 16, 2013
@jakzal jakzal mentioned this pull request Jun 17, 2013
Merged
fabpot added a commit that referenced this pull request Jun 17, 2013
@fabpot
merged branch jakzal/bugfix/di-tests-segfault (PR #8298)
e01c6c2 
This PR was merged into the 2.3 branch.

Discussion
----------

[DependencyInjection] Replaced try/catch block with an @ExpectedException annotation

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This fix doesn't seem like changing anything but thanks to it, PHP 5.3.3 stops segfaulting.

Tests started failing after merging #8285. However, it's not the change which made them failing (the change is totally unrelated to the segfaulting test case). I suspect it has something to do with memory management in the early PHP 5.3 versions. We've had this kind of failures in the past.

Commits
-------

494e803 [DependencyInjection] Replaced try/catch block with an @ExpectedException annotation in a test.
@jakzal jakzal deleted the bugfix/table-helper-multi-byte branch June 19, 2013 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakzal @fabpot
0