[Templating|FrameworkBundle] Made DelegatingEngine::getEngine() public #8280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what is the use case for making it public ? |
|
see the linked ticket. The PHP engine is crippled compared to the twig engine without this change. |
fabpot
added a commit
that referenced
this pull request
Jun 17, 2013
This PR was merged into the master branch. Discussion ---------- [Templating|FrameworkBundle] Made DelegatingEngine::getEngine() public | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7254 | License | MIT | Doc PR | - As a bonus I've covered both classes with tests. Commits ------- a54cbff [FrameworkBundle] Made DelegatingEngine::getEngine() public. 3f84cd3 [Templating] Made DelegatingEngine::getEngine() public. 0a72a99 [FrameworkBundle] Added tests for the DelegatingEngine. 6c31ab2 [Templating] Added tests for the DelegatingEngine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a bonus I've covered both classes with tests.