[DomCrawler] fixed HTML5 form attribute handling #8197
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $fieldNodes = $xpath->query('descendant::input | descendant::button | descendant::textarea | descendant::select', $root); | ||
| foreach ($fieldNodes as $node) { | ||
| // if the descendant element has an HTML5 form attribute, it should match the parent form id | ||
| if (!$node->hasAttribute('form') || ($this->node->hasAttribute('id') && $this->node->getAttribute('id') == $node->getAttribute('form'))) { |
There was a problem hiding this comment.
$this->node->hasAttribute('id') will always be false here as you are in the else part.
| $node = $document->importNode($this->node->ownerDocument->documentElement, true); | ||
| $root->appendChild($node); | ||
| $formNode = $xpath->query(sprintf("//form[@id=%s]", Crawler::xpathLiteral($this->node->getAttribute('id'))))->item(0); | ||
| $fieldNodes = $xpath->query('descendant::input | descendant::button | descendant::textarea | descendant::select', $root); |
There was a problem hiding this comment.
you are now querying all input elements in the page. Is it really more efficient than the previous code ?
There was a problem hiding this comment.
Nope. I tried Firefox and it preserved form element order, so I wanted to implement the same way but I am not sure if it really matters. I can change it to a more efficient one if we decide order does not need to be preserved.
There was a problem hiding this comment.
is the order of POST params really relevant ?
|
@fabpot anything missing in this PR ? |
fabpot
added a commit
that referenced
this pull request
Sep 17, 2013
This PR was squashed before being merged into the 2.3 branch (closes #8197). Discussion ---------- [DomCrawler] fixed HTML5 form attribute handling Fixed HTML5 form attribute handling and improved a test case to test more thoroughly | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6239 | License | MIT | Doc PR | no Commits ------- 04e730e [DomCrawler] fixed HTML5 form attribute handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
2CC0
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed HTML5 form attribute handling and improved a test case to test more thoroughly