[HttpKernel] instantiate valid commands only #8182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| public function __construct($example, $name = 'bar') | ||
| { | ||
|
|
There was a problem hiding this comment.
maybe adding a comment which states that this is not a valid command and therefore should be skipped by the Kernel?
fabpot
added a commit
that referenced
this pull request
Jun 4, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [HttpKernel] instantiate valid commands only | Q | A | ------------- | --- | Bug fix? | yes | New feature? | debatable .. | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT This skips the default behavior to instantiate `Command` that cannot simply be instantiated. The respective commands have to be registered by other means. Commits ------- afad9c7 instantiate valid commands only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skips the default behavior to instantiate
Commandthat cannot simply be instantiated. The respective commands have to be registered by other means.