10000 [Process] Fixed issue where $env or $_ENV can contain array values by mmucklo · Pull Request #8123 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Process] Fixed issue where $env or $_ENV can contain array values #8123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

[Process] Fixed issue where $env or $_ENV can contain array values #8123

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
91b8490
Fix Crawler::children() to not trigger a notice for childless node
lazyhammer May 16, 2013
419f0f0
merged branch lazyhammer/issue-8048 (PR #8054)
fabpot May 16, 2013
1469953
[CssSelector] Fix :nth-last-child() translation
lazyhammer May 17, 2013
5c317b7
[Console] fix and refactor exit code handling
Tobion May 17, 2013
b31769b
merged branch lazyhammer/issue-8068-2.1 (PR #8073)
fabpot May 19, 2013
7b5e680
Merge branch '2.1' into 2.2
fabpot May 19, 2013
92399ff
merged branch Tobion/console-exit-code (PR #8080)
fabpot May 19, 2013
f213a85
Merge branch '2.1' into 2.2
fabpot May 19, 2013
5d750ae
[Process] fix issue where env contains array vals
mmucklo May 23, 2013
6ceb4c3
[Process] fix issue where env contains array vals mmucklo May 23, 2013
a5c3162
Merge branch 'ticket_7196' of github.com:mmucklo/symfony into ticket_…
mmucklo May 23, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix Crawler::children() to not trigger a notice for childless node
  • Loading branch information
@lazyhammer
lazyhammer committed May 16, 2013
commit 91b84903b7924d2295da07dfdea22afb8ffd0d9c
4 changes: 3 additions & 1 deletion src/Symfony/Component/DomCrawler/Crawler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,9 @@ public function children()
throw new \InvalidArgumentException('The current node list is empty.');
}

return new static($this->sibling($this->getNode(0)->firstChild), $this->uri);
$node = $this->getNode(0)->firstChild;

return new static($node ? $this->sibling($node) : array(), $this->uri);
}

/**
Expand Down
8 changes: 8 additions & 0 deletions src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,14 @@ public function testChildren()
} catch (\InvalidArgumentException $e) {
$this->assertTrue(true, '->children() throws an \InvalidArgumentException if the node list is empty');
}

try {
$crawler = new Crawler('<p></p>');
$crawler->filter('p')->children();
$this->assertTrue(true, '->children() does not trigger a notice if the node has no children');
} catch (\PHPUnit_Framework_Error_Notice $e) {
$this->fail('->children() does not trigger a notice if the node has no children');
}
}

public function testParents()
Expand Down
0