[Serializer] Fatal error in denormalizeObject for Normalizers that do not implement DenormalizerInterface #7971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 .. there are a few CS issues to fix though. |
| @@ -239,7 +239,8 @@ private function normalizeObject($object, $format = null, array $context = array | |||
| } | |||
|
|
|||
| foreach ($this->normalizers as $normalizer) { | |||
| if ($normalizer->supportsNormalization($object, $format)) { | |||
| if ($normalizer instanceof NormalizerInterface | |||
| && $normalizer->supportsNormalization($object, $format)) { | |||
There was a problem hiding this comment.
we format multi line if's like so:
if ($normalizer instanceof NormalizerInterface
&& $normalizer->supportsNormalization($object, $format)
) {
fabpot
added a commit
that referenced
this pull request
May 8, 2013
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #7971). Discussion ---------- [Serializer] Fatal error in denormalizeObject for Normalizers that do not implement DenormalizerInterface | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | 7971 | License | MIT | Doc PR | If there is a list of Normalizers, and only some of them implement DenormalizerInterface, then a call to deserialize() can result in a fatal error. This is because denormalizeObject does not check that the Normalizer implements DenormalizerInterface before calling supportsDenormalization on it. Commits ------- cacca2f [Serializer] Fixed fatal error in normalize/denormalizeObject.
fabpot
added a commit
that referenced
this pull request
May 8, 2013
fabpot
added a commit
that referenced
this pull request
May 10, 2013
* 2.2: fixed CS Fixed XML syntax. Fixed parsing of leading blank lines in folded scalars. Closes #7989. [Form] Fixed a method name. Added a test case for Loader::import(). Fixed Loader import [Console] Added dedicated testcase for HelperSet class [Serializer] fixed CS (refs #7971) Fixed fatal error in normalize/denormalizeObject. Fixed 2 namespaces Conflicts: src/Symfony/Component/HttpKernel/Debug/ErrorHandler.php src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a list of Normalizers, and only some of them implement DenormalizerInterface, then a call to deserialize() can result in a fatal error.
This is because denormalizeObject does not check that the Normalizer implements DenormalizerInterface before calling supportsDenormalization on it.