8000 [Form] Fixed transform()/reverseTransform() to always throw TransformationFailedExceptions by webmozart · Pull Request #7917 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Fixed transform()/reverseTransform() to always throw TransformationFailedExceptions #7917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2013
Merged

[Form] Fixed transform()/reverseTransform() to always throw TransformationFailedExceptions #7917

merged 1 commit into from
May 3, 2013

Conversation

webmozart
Copy link
Contributor
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #7558
License MIT
Doc PR -

stloyd
stloyd reviewed May 3, 2013
View reviewed changes
...ony/Component/Form/Tests/Extension/Core/DataTransformer/ValueToDuplicatesTransformerTest.php
@@ -111,7 +111,8 @@ public function testReverseTransformDifferences()
}

/**
* @expectedException Symfony\Component\Form\Exception\UnexpectedTypeException
=======
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong merge here =)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, fixed :)

@webmozart webmozart mentioned this pull request May 3, 2013
Closed
fabpot added a commit that referenced this pull request May 3, 2013
@fabpot
merged branch bschussek/issue7558 (PR #7917)
0a8c2dd 
This PR was merged into the 2.1 branch.

Discussion
----------

[Form] Fixed transform()/reverseTransform() to always throw TransformationFailedExceptions

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #7558
| License       | MIT
| Doc PR        | -

Commits
-------

bcb5400 [Form] Fixed transform()/reverseTransform() to always throw TransformationFailedExceptions
@fabpot fabpot merged commit bcb5400 into symfony:2.1 May 3, 2013
@Tobion
Copy link
Contributor
Tobion commented May 3, 2013

I agree with this PR. But I don't see why this has allegedly no BC impact? It definitely breaks bc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@webmozart @Tobion @stloyd @fabpot
0