8000 Mitigate dependency upon ConfigCache by mpdude · Pull Request #7753 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Mitigate dependency upon ConfigCache #7753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Mitigate dependency upon ConfigCache #7753

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
30a1e32
Introduce the CacheFileUtils helper
mpdude Apr 21, 2013
669898b
Revert newly introduced dependency
mpdude Apr 21, 2013
ed861ba
Remove unused methods.
mpdude Apr 21, 2013
bbb884b
Move the remaining method from CacheFileUtils to the Filesystem class
mpdude Apr 21, 2013
249abb3
Bug introduced when turning the condition around
mpdude Apr 21, 2013
327befe
With dumpFile() in the Filesystem class, the mode must be a param.
mpdude Apr 21, 2013
a490486
Added entry for new dumpFile() method
mpdude Apr 21, 2013
6da1b0a
Use method here as well
mpdude Apr 21, 2013
ad47bc4
Make method private + fix CS #fail
mpdude Apr 21, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bug introduced when turning the condition around
  • Loading branch information
@mpdude
mpdude committed Apr 21, 2013
commit 249abb38516dacec3cc3015f3465161888b9ae7d
2 changes: 1 addition & 1 deletion src/Symfony/Component/Filesystem/Filesystem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ public function dumpFile($filename, $content)

$tmpFile = tempnam($dir, basename($filename));

if (false !== @file_put_contents($tmpFile, $content)) {
if (false === @file_put_contents($tmpFile, $content)) {
throw new IOException(sprintf('Failed to write file "%s".', $filename));
}

Expand Down
0