[Form] Make exception handling consistent with other components #7706
Conversation
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #6544 |
| License | MIT |
|
ping @bschussek |
|
@bschussek no problem, I'll wait. |
|
IMO renaming/removing even things like exceptions IS a BC-Break and should be mentioned in changelog/update documents. |
|
Both PRs referenced by @bschussek have been merged now. And Yes, this is a BC break. |
|
I think it is not necessary to rename any exception. Otherwise this PR should be fine in terms of BC. |
|
A bit later today I'll make rebase and update changelog file. |
|
Thank you! I would appreciate if you could check the full component code again for "old-style" exceptions, because a couple of older PRs were merged recently. Their exception code possibly needs to be adapted too. |
|
Rebased. @bschussek plz review this. |
|
Sorry for closing |
| @@ -27,7 +27,7 @@ | |||
| * | |||
| * @return FormInterface The form named after the type | |||
| * | |||
| * @throws Exception\FormException if any given option is not applicable to the given type | |||
| * @throws \Symfony\Component\OptionsResolver\Exception\\InvalidOptionsException if any given option is not applicable to the given type | |||
|
Apart from my comments, this PR looks very good! Thank you! :) |
|
For everybody confused by the diff view, the "renamed" exceptions are really just removed (because unused) exceptions and new exceptions that Git wrongly considers "renamed". |
|
updated. |
|
@bschussek not at all. It's pleasure to me to be a part of great community :) |
|
Could you please squash the commits into a single commit? |
|
done |
This PR was merged into the master branch. Discussion ---------- [Form] Make exception handling consistent with other components | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6544 | License | MIT Commits ------- bf9382e [Form] Make exception handling consistent with other components