[Validator] Moved constraints Optional and Required to the Constraints\ namespace #7701
Conversation
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | symfony/symfony-docs#2512 |
| /** | ||
| * @author Bernhard Schussek <bschussek@gmail.com> | ||
| */ | ||
| abstract class Existence extends Constraint |
There was a problem hiding this comment.
what is the goal of this abstract class you are introducing ? This looks weird as you are not even uisng it for the instanceof checks
There was a problem hiding this comment.
It was introduced because Optional and Required are two constraints of a kind that will probably always have identical functionality (I discovered that when trying to fix #4453 but didn't have time to complete this fix).
This PR was merged into the master branch. Discussion ---------- [Validator] Moved constraints Optional and Required to the Constraints\ namespace | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#2512 Commits ------- a868048 [Validator] Moved constraints Optional and Required to the Constraints\ namespace
|
@webmozart why were these classes moved? As far as I can tell they can only work with the collection constraint. Is that correct (see #11014)? |
|
@jakzal to make it easier to use them without a second use statement (in Yaml or XML, it would require to either define namespace aliases or use the FQCN otherwise) |
|
@stof cool, thanks! I thought there was an idea of using them outside of the Collection constraint. Looks like not ;) |