8000 [Security/Http/RememberMe] PersistentTokenBasedRememberMeServices bugfix by TerjeBr · Pull Request #7534 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Security/Http/RememberMe] PersistentTokenBasedRememberMeServices bugfix #7534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2013
Merged

[Security/Http/RememberMe] PersistentTokenBasedRememberMeServices bugfix #7534

merged 1 commit into from
Apr 1, 2013

Conversation

TerjeBr
Copy link
@TerjeBr TerjeBr commented Mar 31, 2013
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

The database and debug layer cannot handle raw random strings. It may contain invalid ut8 characters and whatnot. So, in order to avoid a lot of database bugs, we must base64_encode the random strings.

fabpot added a commit that referenced this pull request Apr 1, 2013
This PR was merged into the 2.2 branch.

Discussion
----------

[Security/Http/RememberMe] PersistentTokenBasedRememberMeServices bugfix

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass? | yes
| License       | MIT

The database and debug layer cannot handle raw random strings. It may contain invalid ut8 characters and whatnot. So, in order to avoid a lot of database bugs, we must base64_encode the random strings.

Commits
-------

751abe1 Doctrine cannot handle bare random non-utf8 strings
@fabpot fabpot merged commit 751abe1 into symfony:2.2 Apr 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0