[Form] [Doctrine] [EntityChoiceList] idAsIndex should be true with a smallint id field. #7519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Apr 1, 2013
This PR was merged into the 2.1 branch. Discussion ---------- [Form] [Doctrine] [EntityChoiceList] idAsIndex should be true with a smallint id field. When the id of an entity is a smallint, $this->idAsIndex should also be true. It was not the case. Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: should License of the code: MIT Commits ------- 673fd9b idAsIndex should be true with a smallint or bigint id field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the id of an entity is a smallint, $this->idAsIndex should also be true.
It was not the case.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: should
License of the code: MIT