[2.2] sub-requests are now created with the same class as their parent #7390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,7 +89,7 @@ protected function createSubRequest($uri, Request $request) | |||
| // the sub-request is internal | |||
| $server['REMOTE_ADDR'] = '127.0.0.1'; | |||
|
|
|||
| $subRequest = Request::create($uri, 'get', array(), $cookies, array(), $server); | |||
| $subRequest = $request::create($uri, 'get', array(), $cookies, array(), $server); | |||
There was a problem hiding this comment.
Does it make sense to invoke static methods on objects?
There was a problem hiding this comment.
I know it's weird, but it makes sense.
See comments in #7381.
fabpot
added a commit
that referenced
this pull request
Mar 18, 2013
This PR was merged into the 2.2 branch. Commits ------- 53cf12b replaced new occurences of 'Request::create()' with '::create()' Discussion ---------- [2.2] sub-requests are now created with the same class as their parent Following #7381 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7185, #7186
1 task
fabpot
added a commit
that referenced
this pull request
Oct 1, 2013
…ss (fabpot) This PR was merged into the master branch. Discussion ---------- [HttpFoundation] added a way to override the Request class | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7461, #7453 | License | MIT | Doc PR | symfony/symfony-docs#3021 This is an alternative implementation for #7461. I've also reverted #7381 and #7390 as these changes are not needed anymore. Todo: - [ ] add some tests Commits ------- 464439d [HttpFoundation] added a way to override the Request class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #7381