8000 Add extension apc.so to Travis-CI testing by aitboudad · Pull Request #7355 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Add extension apc.so to Travis-CI testing #7355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add extension apc.so to Travis-CI testing #7355

wants to merge 1 commit into from

Conversation

aitboudad
Copy link
Contributor

@aitboudad
Update .travis.yml
164c2cd 
Add extension apc.so to Travis-CI testing
@pborreli
Copy link
Contributor

are you sure apc.enable_cli is On ?

@aitboudad
Copy link
Contributor Author

@pborreli no I'm not sure, have you any idea of how check if is it "On"?

@pborreli
Copy link
Contributor

i think it is as you make more assertions than before, but you can test it with php -i | grep enable_cli inside your before_script section of .travis.yml on another branch.

@aitboudad
Copy link
Contributor Author

Ok I will do it.

@liuggio
Copy link
Contributor
liuggio commented Mar 12, 2013

Sorry I don't get which is the benefit of enablig APC by default in the
test (apart speed)?

On Wed, Mar 13, 2013 at 12:23 AM, Abdellatif AitBoudad <
notifications@github.com> wrote:

no I'm not sure, have you any idea of how check if is it "On"?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/7355#issuecomment-14812533
.

liuggio_______________

/|_ We reject kings, presidents and voting.
/o ) / We believe in rough consensus
) v _/\ and running code (I.E.T.F. credo)

@pborreli
Copy link
Contributor

@liuggio i guess it won't give any speed gain but/because it will execute all the skipped assertion when apc is not enabled

@aitboudad
Copy link
Contributor Author

@pborreli

apc.enable_cli => Off => Off
but can be enabled by adding if necessary:

 echo "apc.enable_cli = 1" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini

@fabpot
Copy link
Member
fabpot commented Mar 18, 2013

You need to enable APC for the CLI so that tests that requires APC won't be skipped. If not, that's useless.

@stof
Copy link
Member
stof commented Mar 18, 2013

@fabpot apc.enable_cli controls the opcode cache AFAIK, not the user cache (which is the one needed for the tests)

@pborreli
Copy link
Contributor

yes that's why adding apc.so was enough to unskip those assertions.
so 👍 for this PR and 👎 for enable_cli

fabpot pushed a commit that referenced this pull request Mar 20, 2013
@aitboudad @fabpot
Update .travis.yml (closes #7355)
f2da7f1 
Add extension apc.so to Travis-CI testing
@fabpot fabpot closed this Mar 20, 2013
fabpot added a commit that referenced this pull request Mar 23, 2013
@fabpot
Merge branch '2.1' into 2.2
03fc97d 
* 2.1:
  #7106 - fix for ZTS builds
  Added '@@' escaping strategy for YamlFileLoader and YamlDumper
  [Yaml] fixed bugs with folded scalar parsing
  [Form] made DefaultCsrfProvider using session_status() when available
  Added unit tests to Dumper
  Update .travis.yml (closes #7355)
  [HttpFoudantion] fixed Request::getPreferredLanguage()
  Revert "merged branch jfsimon/issue-6928 (PR #7378)"
  Routing issue with installation in a sub-directory ref: #7129

Conflicts:
	.travis.yml
	src/Symfony/Bundle/FrameworkBundle/Routing/Router.php
	src/Symfony/Component/Routing/RouteCollection.php
fabpot added a commit that referenced this pull request Mar 23, 2013
@fabpot
Merge branch '2.2'
77ec799 
* 2.2:
  #7106 - fix for ZTS builds
  Added '@@' escaping strategy for YamlFileLoader and YamlDumper
  [Yaml] fixed bugs with folded scalar parsing
  [Form] made DefaultCsrfProvider using session_status() when available
  Added unit tests to Dumper
  Update .travis.yml (closes #7355)
  [HttpFoudantion] fixed Request::getPreferredLanguage()
  Revert "merged branch jfsimon/issue-6928 (PR #7378)"
  Routing issue with installation in a sub-directory ref: #7129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aitboudad @pborreli @liuggio @fabpot @stof
0