[HttpFoundation] Remove Cache-Control when using https download via IE<9 (fixes #6750) #7153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #6750 |
| License | MIT |
| Doc PR |
| * Check if we need to remove Cache-Control for ssl encrypted downloads when using IE < 9 | ||
| * @link http://support.microsoft.com/kb/323308 | ||
| */ | ||
| if (false !== stripos($this->headers->get('Content-Disposition'), 'attachment') && preg_match('/(?i)msie [1-8]/', $request->server->get('HTTP_USER_AGENT')) && null === $request->server->get('HTTPS')) { |
There was a problem hiding this comment.
You should replace null === $request->server->get('HTTPS') by $request->isSecure().
There was a problem hiding this comment.
this regex would match IE 10+ while it does not match IE9. Is it intended ?
There was a problem hiding this comment.
and btw, using a case-sensitivity modifer inside the regex is useless here. You could simply apply the i modifier on the whole regex(/msie [1-8]/i)
fabpot
added a commit
that referenced
this pull request
Feb 22, 2013
This PR was squashed before being merged into the 2.1 branch (closes #7153). Commits ------- b2080c4 [HttpFoundation] Remove Cache-Control when using https download via IE<9 (fixes #6750) Discussion ---------- [HttpFoundation] Remove Cache-Control when using https download via IE<9 (fixes #6750) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6750 | License | MIT | Doc PR |
fabpot
added a commit
that referenced
this pull request
Apr 12, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [HTTPFoundation] Fix download over SSL using IE < 8 and binary file response | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | related to #7153 Commits ------- 4c51ec7 Fix download over SSL using IE < 8 and binary file response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.