8000 Expanded fault-tolerance for unusual cookie dates by ecaron · Pull Request #7149 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Expanded fault-tolerance for unusual cookie dates #7149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Expanded fault-tolerance for unusual cookie dates #7149

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b14cef7
Added 2 more possible date formats to recognize, and a fallback strto…
ecaron Feb 21, 2013
f797f52
Including adjusted test cases and moving from strtotime to date_create
ecaron Feb 21, 2013
9ebec8a
Re-incorporating a typo that was meant to be included
ecaron Feb 21, 2013
0baa232
Fixing a tab that slipped through (which violated PSR-2)
ecaron Feb 21, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-incorporating a typo that was meant to be included
  • Loading branch information
@ecaron
ecaron committed Feb 21, 2013
commit 9ebec8aebc78e0073887d9b4c0fb877904df4585
2 changes: 1 addition & 1 deletion src/Symfony/Component/BrowserKit/Tests/CookieTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public function testFromStringThrowsAnExceptionIfCookieIsNotValid()
public function testFromStringThrowsAnExceptionIfCookieDateIsNotValid()
{
$this->setExpectedException('InvalidArgumentException');
Cookie::FromString('foo=bar; expires=Friday July 31st 2020, 08:49:37 GMT');
Cookie::FromString('foo=bar; expires=Flursday July 31st 2020, 08:49:37 GMT');
}

public function testFromStringThrowsAnExceptionIfUrlIsNotValid()
Expand Down
0