[2.3] [WebProfiler] added the possibility to override the application name/version in the WDT #7003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
| @@ -5,10 +5,21 @@ | |||
| {% set icon %} | |||
| <a href="http://symfony.com/"> | |||
There was a problem hiding this comment.
would it me sense to have this configurable ?
There was a problem hiding this comment.
@vicb IMO I think yes... Think about other sf2 framework distributions eg: knp rad edition, it would be good to refer to them when user use their sf2 mix
There was a problem hiding this comment.
I agree with @canni on this one.
…version in the WDT
fabpot
added a commit
that referenced
this pull request
Mar 23, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [2.3] [WebProfiler] added the possibility to override the application name/version in the WDT | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- d35cb9f [WebProfiler] added the possibility to override the application name/version in the WDT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.