[Validator] gracefully handle transChoice errors #6988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @fabpot Any thoughts on this change? Having to provide a transChoice template when you know what the pluralization is going to be is a pain in the neck. |
|
ping @bschussek too :) |
|
I'm +1 for this change. What do you think @bschussek? |
|
Would this be a common enough use case to be pushed to the translator ? |
fabpot
added a commit
that referenced
this pull request
Feb 28, 2013
This PR was merged into the 2.2 branch. Commits ------- da22926 [Validator] gracefully handle transChoice errors Discussion ---------- [Validator] gracefully handle transChoice errors This validator annotation was throwing an error for me: ``` /** @Assert\Length(min=6, minMessage="Must be 6 characters") */ ``` To avoid this error in the current code I would need to provide a message template that accommodates the minimum length being 1, even though that's not the case. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ --------------------------------------------------------------------------- by kriswallsmith at 2013-02-25T19:41:51Z ping @fabpot Any thoughts on this change? Having to provide a transChoice template when you know what the pluralization is going to be is a pain in the neck. --------------------------------------------------------------------------- by kriswallsmith at 2013-02-25T19:42:11Z ping @bschussek too :) --------------------------------------------------------------------------- by fabpot at 2013-02-25T19:57:08Z I'm +1 for this change. What do you think @bschussek? --------------------------------------------------------------------------- by vicb at 2013-02-26T10:44:33Z Would this be a common enough use case to be pushed to the translator ?
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validator annotation was throwing an error for me:
To avoid this error in the current code I would need to provide a message template that accommodates the minimum length being 1, even though that's not the case.