Remove executable bit from all PHP files #6933
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TravisCarden Almsot right ! You should not send a PR from your master branch: the PR would get updated when your master branch is updated - this is true for any branch. I think creating a feature branch is described in the contributor guide. If you need more help, ping me. You will have to close this PR and reopen a new one. I think some code review bots can automatically check the x bit but they are not enabled on this repo. |
fabpot
added a commit
that referenced
this pull request
Jan 31, 2013
This PR was merged into the master branch. Commits ------- 924c256 Remove executable bit from all PHP files Discussion ---------- Remove executable bit from all PHP files | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | | Fixed tickets | | License | MIT | Doc PR | Apologies if I haven't got the protocol quite right here. This is my first interaction with this project. By the way, I've noticed a non-trivial number of pull requests to remove executable bits. Could there be an automated test to prevent files getting into the repo with them on in the first place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies if I haven't got the protocol quite right here. This is my first interaction with this project.
By the way, I've noticed a non-trivial number of pull requests to remove executable bits. Could there be an automated test to prevent files getting into the repo with them on in the first place?