removed deprecated messages coming for internal calls #6868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The cases where you should actually be warned about the deprecation of FieldType is when using |
|
@stof: what do you mean? That we can remove the |
|
Nobody will ever instantiate the FieldType directly as the framework is registering it (btw, you are missing the FrameworkBundle lazy registration here). |
|
@stof: I've updated the PR to remove the |
fabpot
added a commit
that referenced
this pull request
Jan 24, 2013
This PR was merged into the master branch. Commits ------- ed64413 removed deprecated message in FieldType Discussion ---------- removed deprecated messages coming for internal calls | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6407 | License | MIT | Doc PR | n/a It's probably not the cleanest code possible, but I don't see any other way to keep the type for BC and avoid the deprecated message when called internally. That should fix the deprecated messages thrown by the Form and Validator components. --------------------------------------------------------------------------- by stof at 2013-01-24T15:41:26Z The cases where you should actually be warned about the deprecation of FieldType is when using ``field`` to create a field with the factory (which would not trigger the constructor) --------------------------------------------------------------------------- by fabpot at 2013-01-24T15:46:23Z @stof: what do you mean? That we can remove the `trigger_error()` call altogether? --------------------------------------------------------------------------- by stof at 2013-01-24T15:49:31Z Nobody will ever instantiate the FieldType directly as the framework is registering it (btw, you are missing the FrameworkBundle lazy registration here). The constructor of a form type is not the right place to deprecate it as registering it does not mean it will be used in the app. --------------------------------------------------------------------------- by fabpot at 2013-01-24T15:51:26Z @stof: I've updated the PR to remove the `trigger_error` call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably not the cleanest code possible, but I don't see any other way to keep the type for BC and avoid the deprecated message when called internally.
That should fix the deprecated messages thrown by the Form and Validator components.