fixed a circular reference (closes #6730) #6850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #6730 |
| License | MIT |
| Doc PR | n/a |
|
shoudln't this be moved to the component ? Someone using the TwigBridge, HttpKernel and the DI component outside the full stack framework (let's say Drupal maybe) would also face the circular reference issue |
|
No, they won't as the problem is only if you are using the templating component. So, Silex or Drupal won't have the problem. |
|
ah, the issue is indeed with the TwigEngine, not with the Twig_Environment service. |
fabpot
added a commit
that referenced
this pull request
Jan 23, 2013
This PR was merged into the master branch. Commits ------- 65b4112 fixed a circular reference (closes #6730) Discussion ---------- fixed a circular reference (closes #6730) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6730 | License | MIT | Doc PR | n/a --------------------------------------------------------------------------- by stof at 2013-01-23T13:56:19Z shoudln't this be moved to the component ? Someone using the TwigBridge, HttpKernel and the DI component outside the full stack framework (let's say Drupal maybe) would also face the circular reference issue --------------------------------------------------------------------------- by fabpot at 2013-01-23T13:58:28Z No, they won't as the problem is only if you are using the templating component. So, Silex or Drupal won't have the problem. --------------------------------------------------------------------------- by stof at 2013-01-23T14:01:03Z ah, the issue is indeed with the TwigEngine, not with the Twig_Environment service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.