[HttpKernel] refactored the HTTP content renderer to make it easier to extend #6810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| * | ||
| * @return string|null The Response content or null when the Response is streamed | ||
| * | ||
| * @throws \RuntimeException when the Response is not successful |
There was a problem hiding this comment.
public function render should also document this exception.
fabpot
added a commit
that referenced
this pull request
Jan 21, 2013
This PR was merged into the master branch. Commits ------- aadefd3 [HttpKernel] refactored the HTTP content renderer to make it easier to extend Discussion ---------- [HttpKernel] refactored the HTTP content renderer to make it easier to extend | Q | A | ------------- | --- | Bug fix? | no | New feature? | kinda | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This makes the StreamedResponse logic reusable for other strategies and it also makes the RenderingStrategy interface less fuzzy about its contract. That also makes features like #4470 easier to implement from the outside. --------------------------------------------------------------------------- by stof at 2013-01-20T11:01:29Z :+1:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the StreamedResponse logic reusable for other strategies and it also makes the RenderingStrategy interface less fuzzy about its contract.
That also makes features like #4470 easier to implement from the outside.