10000 [Console] Removing unnecessary sprintf in Application->getHelp by gnugat · Pull Request #6789 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Removing unnecessary sprintf in Application->getHelp #6789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Console] Removing unnecessary sprintf in Application->getHelp #6789

wants to merge 2 commits into from

Conversation

gnugat
Copy link
Contributor
@gnugat gnugat commented Jan 18, 2013

Minor change of the Symfony\Component\Console\Application->getHelp() method.

I have spotted:

  1. an unnecessary sprintf call (no args arguments);
  2. two ways of adding a new line in the help (an empty string as new entry of the array and a \n at the end of the string).

It seems to be there since the begining and it looks like a forgoten change to me, so I fixed them by removing the sprintf call and using a new array entry (empty string) instead of the \n.

Q A
License MIT

@fabpot fabpot closed this in d120117 Jan 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnugat @fabpot
0