Routing options #6738
Merged
Routing options #6738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it uses an attribute list instead of multiple scheme/method elements that I also experimented with
| public function setPattern($pattern) | ||
| { | ||
| $this->pattern = $pattern; | ||
| $this->path = $pattenr; |
There was a problem hiding this comment.
typo
|
I agree it should be done in 2.2. Thanks for working on it. |
| @@ -100,10 +100,10 @@ private function compilePattern(Route $route, $pattern, $isHostname) | |||
| $isSeparator = '' !== $precedingChar && false !== strpos(static::SEPARATORS, $precedingChar); | |||
|
|
|||
| if (is_numeric($varName)) { | |||
| throw new \DomainException(sprintf('Variable name "%s" cannot be numeric in route pattern "%s". Please use a different name.', $varName, $pattern)); | |||
| throw new \DomainException(sprintf('Variable name "%s" cannot be numeric in route path "%s". Please use a different name.', $varName, $pattern)); | |||
There was a problem hiding this comment.
path still wrong (multiple occurences also below)
|
@fabpot "Everything is BC" until it breaks BC in 3.0, that's why I'd like to see deprecations in PR summary what do you think ? |
|
it would also be great to update the CHANGELOG with deprecations (it could also help people answering your question) |
|
@vicb: I've just updated the CHANGELOG and created the UPGRADE file for 3.0. |
|
@fabpot thanks. |
| @@ -115,12 +142,38 @@ public function getPattern() | |||
| * @param string $pattern The pattern | |||
| * | |||
| * @return Route The current Route instance | |||
| * | |||
| * @deprecated Deprecated in 2.3, to be removed in 3.0 | |||
There was a problem hiding this comment.
It should say it's deprecated in 2.2 since we want to merge it there. Also please mention to use
fabpot
added a commit
that referenced
this pull request
Jan 15, 2013
This PR was merged into the master branch. Commits ------- 9fc7def added the UPGRADE file for Symfony 3.0 e84cad2 [Routing] updated CHANGELOG 65eca8a [Routing] added new schemes and methods options to the annotation loader 5082994 [Routing] renamed pattern to path b357caf [Routing] renamed hostname pattern to just hostname e803f46 made schemes and methods available in XmlFileLoader d374e70 made schemes and methods available in YamlFileLoader 2834e7e added scheme and method setter in RouteCollection 10183de make scheme and method requirements first-class citizen in Route Discussion ---------- Routing options | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #5989, #5990, #6049 | License | MIT In #5989, it has unanimously been decided to renamed `hostname_pattern` to `hostname` and `pattern` to `path`. That makes a lot of sense and I would like to do the renaming now as `hostname_pattern` is new in Symfony 2.2, so I'd like to avoid breaking BC just after the release. As we are modifying the route options, I've also included changes introduced by @Tobion in #6049 which were discussed in #5990. As everything is BC, I think it's wise to include that in 2.2. What do you think? --------------------------------------------------------------------------- by Tobion at 2013-01-14T18:25:53Z I agree it should be done in 2.2. Thanks for working on it. --------------------------------------------------------------------------- by vicb at 2013-01-14T23:11:12Z @fabpot "Everything is BC" until it breaks BC in 3.0, that's why I'd like to see [deprecations in PR summary](symfony/symfony-docs#2116) what do you think ? --------------------------------------------------------------------------- by vicb at 2013-01-14T23:16:40Z it would also be great to update the CHANGELOG with deprecations (it could also help people answering your question) --------------------------------------------------------------------------- by fabpot at 2013-01-15T07:07:03Z @vicb: I've just updated the CHANGELOG and created the UPGRADE file for 3.0. --------------------------------------------------------------------------- by vicb at 2013-01-15T07:15:32Z @fabpot thanks.
This was referenced Jan 20, 2013
|
We should also change the arguments of |
| schemes: https | ||
| requirements: { 'id': '\d+' } | ||
|
|
||
| <route id="article_edit" pattern="/article/{id}" methods="POST PUT" schemes="https"> |
There was a problem hiding this comment.
should be path here as it is the after example right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5989, it has unanimously been decided to renamed
hostname_patterntohostnameandpatterntopath. That makes a lot of sense and I would like to do the renaming now ashostname_patternis new in Symfony 2.2, so I'd like to avoid breaking BC just after the release. As we are modifying the route options, I've also included changes introduced by @Tobion in #6049 which were discussed in #5990.As everything is BC, I think it's wise to include that in 2.2. What do you think?