-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[WIP] Kernel refactor #6459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[WIP] Kernel refactor #6459
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9aaceb1
moved the logic from HttpKernel in FrameworkBundle to the HttpKernel …
fabpot a0c49c3
[TwigBridge] added a render_* function to ease usage of custom render…
fabpot 892f00f
[HttpKernel] added a URL signer mechanism for hincludes
fabpot 403bb06
[HttpKernel] added missing phpdoc and tweaked existing ones
fabpot 1f1392d
[HttpKernel] simplified and enhanced code managing the hinclude strategy
fabpot adc067e
[FrameworkBundle] made some services private
fabpot 1240690
[HttpKernel] made the strategy a regular parameter in HttpContentRend…
fabpot a8ea4e4
[FrameworkBundle] deprecated HttpKernel::forward() (it is only used o…
fabpot bd102c5
made the content renderer work even when ESI is disabled or when no t…
fabpot 2eea768
moved the deprecation logic calls outside the new HttpContentRenderer…
fabpot f17f586
moved the container aware HTTP kernel to the HttpKernel component
fabpot f7da1f0
added some unit tests (and fixed some bugs)
fabpot 76fefe3
updated CHANGELOG and UPGRADE files
fabpot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[FrameworkBundle] made some services private
- Loading branch information
commit adc067e9386a87f4987275ede03833b74922adeb
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strategies could be marked as private, allowing to inline them in the container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about that, but because of a bug in the PHPDumper, that's not possible for hinclude. I'm working on fixing the bug so that we can use private services later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #6565 for the bug fix