8000 [WIP] Kernel refactor by fabpot · Pull Request #6459 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WIP] Kernel refactor #6459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 11, 2013
Merged

[WIP] Kernel refactor #6459

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9aaceb1
moved the logic from HttpKernel in FrameworkBundle to the HttpKernel …
fabpot Dec 19, 2012
a0c49c3
[TwigBridge] added a render_* function to ease usage of custom render…
fabpot Jan 3, 2013
892f00f
[HttpKernel] added a URL signer mechanism for hincludes
fabpot Jan 3, 2013
403bb06
[HttpKernel] added missing phpdoc and tweaked existing ones
fabpot Jan 4, 2013
1f1392d
[HttpKernel] simplified and enhanced code managing the hinclude strategy
fabpot Jan 4, 2013
adc067e
[FrameworkBundle] made some services private
fabpot Jan 5, 2013
1240690
[HttpKernel] made the strategy a regular parameter in HttpContentRend…
fabpot Jan 6, 2013
a8ea4e4
[FrameworkBundle] deprecated HttpKernel::forward() (it is only used o…
fabpot Jan 6, 2013
bd102c5
made the content renderer work even when ESI is disabled or when no t…
fabpot Jan 6, 2013
2eea768
moved the deprecation logic calls outside the new HttpContentRenderer…
fabpot Jan 6, 2013
f17f586
moved the container aware HTTP kernel to the HttpKernel component
fabpot Jan 6, 2013
f7da1f0
added some unit tests (and fixed some bugs)
fabpot Jan 10, 2013
76fefe3
updated CHANGELOG and UPGRADE files
fabpot Jan 10, 2013 8000
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[FrameworkBundle] made some services private
  • Loading branch information
@fabpot
fabpot committed Jan 10, 2013
commit adc067e9386a87f4987275ede03833b74922adeb
5 changes: 3 additions & 2 deletions src/Symfony/Bundle/FrameworkBundle/Resources/config/content_generator.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,20 @@
<argument>%kernel.debug%</argument>
</service>

<service id="http_content_renderer.strategy.default" class="%http_content_renderer.strategy.default.class%">
<service id="http_content_renderer.strategy.default" class="%http_content_renderer.strategy.default.class%" public="false">
<tag name="kernel.content_renderer_strategy" />
<argument type="service" id="http_kernel" />
<call method="setUrlGenerator"><argument type="service" id="router" /></call>
</service>

<service id="http_content_renderer.strategy.esi" class="%http_content_renderer.strategy.esi.class%">
<service id="http_content_renderer.strategy.esi" class="%http_content_renderer.strategy.esi.class%" public="false">
<tag name="kernel.content_renderer_strategy" />
<argument type="service" id="esi" />
<argument type="service" id="http_content_renderer.strategy.default" />
<call method="setUrlGenerator"><argument type="service" id="router" /></call>
</service>

<!-- FIXME: this service should be private but it cannot due to a bug in PhpDumper -->
<service id="http_content_renderer.strategy.hinclude" class="%http_content_renderer.strategy.hinclude.class%">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strategies could be marked as private, allowing to inline them in the container

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but because of a bug in the PHPDumper, that's not possible for hinclude. I'm working on fixing the bug so that we can use private services later on.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #6565 for the bug fix

<tag name="kernel.content_renderer_strategy" />
<argument type="service" id="templating" />
Expand Down
0