[Messenger] Only send UNLISTEN query if we are actively listening
#63202
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf7f7ae to
0d51464
Compare
UNLISTEN query if we are actively listening
OskarStark
approved these changes
Jan 27, 2026
|
|
||
| private function unlisten(): void | ||
| { | ||
| if (false === $this->listening) { |
Member
There was a problem hiding this comment.
Suggested change
| if (false === $this->listening) { | |
| if (true === (false === $this->listening)) { |
or maybe just this?
Suggested change
| if (false === $this->listening) { | |
| if (!$this->listening) { |
(kidding 😜 )
0d51464 to
5171958
Compare
Member
|
Thank you @jwage. |
This was referenced Jan 28, 2026
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at some slow traces and noticed PostgreSqlConnection::unlisten() being called in the __destruct even when we are using the connection to publish only and we're not consuming, yet on the __destruct() it still send a transaction to pgsql to UNLISTEN when we're not listening.