8000 PHP CS Fixer: enable `@PHP8x1Migration:risky` by keradus · Pull Request #63198 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

PHP CS Fixer: enable @PHP8x1Migration:risky #63198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keradus wants to merge 8 commits into
base: 8.1
Choose a base branch
from
Open

PHP CS Fixer: enable @PHP8x1Migration:risky #63198

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ad4e8c9
temporary apply not-yet-solved CS issues
keradus Jan 26, 2026
71d60ce
enable PHP7x1Migration:risky
keradus Jan 26, 2026
182291a
enable PHP7x4Migration:risky + apply
keradus Jan 26, 2026
7073197
enable PHP8x1Migration:risky
keradus Jan 26, 2026
770a0c7
drop random_api_migration, as it's part of PHP8x1Migration:risky
keradus Jan 26, 2026
476787e
Revert "temporary apply not-yet-solved CS issues"
keradus Jan 26, 2026
f4c66cc
FIX
keradus Jan 28, 2026
1957f6c
kick CI
keradus Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
FIX
  • Loading branch information
@keradus
keradus committed Jan 28, 2026
commit f4c66ccf76585876d751b0a2e071f5cf7de4fc97
6 changes: 5 additions & 1 deletion src/Symfony/Component/Config/Definition/Loader/DefinitionFileLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ public function load(mixed $resource, ?string $type = null): mixed
$this->container?->fileExists($path);

// the closure forbids access to the private scope in the included file
$load = \Closure::bind(static fn ($file) => include $file, null, null);
$load = \Closure::bind(static function ($file) use ($loader) {
return include $file;
}, null, null);

$callback = $load($path);

Expand Down Expand Up @@ -99,3 +101,5 @@ private function callConfigurator(callable $callback, DefinitionConfigurator $co
final class ProtectedDefinitionFileLoader extends DefinitionFileLoader
{
}

// @php-cs-fixer-ignore use_arrow_functions to prevent arrow function overriding callback that includes file in limited context, ref https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/9388
6 changes: 5 additions & 1 deletion src/Symfony/Component/DependencyInjection/Loader/PhpFileLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ class_alias(AppReference::class, App::class);
}

// the closure forbids access to the private scope in the included file
$load = \Closure::bind(static fn ($path, $env) => include $path, null, null);
$load = \Closure::bind(static function ($path, $env) use ($container, $loader, $resource, $type) {
return include $path;
}, null, null);

$instanceof = $this->instanceof;
$this->instanceof = [];
Expand Down Expand Up @@ -205,3 +207,5 @@ private function callConfigurator(callable $callback, ContainerConfigurator $con
}
}
}

// @php-cs-fixer-ignore use_arrow_functions to prevent arrow function overriding callback that includes file in limited context, ref https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/9388
6 changes: 5 additions & 1 deletion src/Symfony/Component/Routing/Loader/PhpFileLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ class_alias(RoutesReference::class, Routes::class);

// the closure forbids access to the private scope in the included file
$loader = $this;
$load = \Closure::bind(static fn ($file) => include $file, null, null);
$load = \Closure::bind(static function ($file) use ($loader) {
return include $file;
}, null, null);

if (1 === $result = $load($path)) {
$result = null;
Expand Down Expand Up @@ -81,3 +83,5 @@ protected function callConfigurator(callable $callback, string $path, string $fi
return $collection;
}
}

// @php-cs-fixer-ignore use_arrow_functions to prevent arrow function overriding callback that includes file in limited context, ref https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/9388
Loading
0