[HttpClient] Cleanup tests #63166
Merged
[HttpClient] Cleanup tests #63166
8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jan 23, 2026
| --header %1$sAccept: */*%1$s \\ | ||
| --header %1$sAccept-Encoding: gzip%1$s \\ | ||
| --header %1$sUser-Agent: Symfony HttpClient (Native)%1$s', | ||
| --url http://localhost:8057/json \\ |
Member
There was a problem hiding this comment.
The way those assertions are written now means that removing the argument escaping in the implementation would not make test fail. Is it really what we want for cleaner tests ?
Member
Author
There was a problem hiding this comment.
the issue is that escaping changes from one version to another 😬
I'm open another way if anyone is up to dig this 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of this cleanup is needed for #63164: command line escaping is going to be different on Windows.