8000 [DependencyInjection] Don't add empty `.container.known_envs` in XML loader by GromNaN · Pull Request #62558 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] Don't add empty .container.known_envs in XML loader #62558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Dec 1, 2025
Merged

[DependencyInjection] Don't add empty .container.known_envs in XML loader #62558

nicolas-grekas merged 1 commit into from
Dec 1, 2025
+2 −5

Conversation

@GromNaN
Copy link
Member
@GromNaN GromNaN commented Nov 28, 2025 •
edited
Loading
Q A
Branch? 7.4
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

The XML loader is the only one that creates the .container.known_envs parameter even if there is no <when env="..."> in the file. The PHP and Yaml loaders read and update this parameter only when they find a when@<env> key.

symfony/src/Symfony/Component/DependencyInjection/Loader/PhpFileLoader.php

Lines 81 to 85 in 1aa580f

if (str_starts_with($namespace, 'when@')) {
$knownEnvs = $this->container->hasParameter('.container.known_envs') ? array_flip($this->container->getParameter('.container.known_envs')) : [];
$this->container->setParameter('.container.known_envs', array_keys($knownEnvs + [substr($namespace, 5) => true]));
continue;
}

symfony/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php

Lines 958 to 962 in 1aa580f

if (str_starts_with($namespace, 'when@')) {
$knownEnvs = $this->container->hasParameter('.container.known_envs') ? array_flip($this->container->getParameter('.container.known_envs')) : [];
$this->container->setParameter('.container.known_envs', array_keys($knownEnvs + [substr($namespace, 5) => true]));
continue;
}

This is causing an issue in symfony-config-xml-to-php when comparing the result of loading equivalent PHP and XML config files. This key is added by the XML loader, not the PHP loader.

@carsonbot carsonbot added this to the 7.4 milestone Nov 28, 2025
@carsonbot carsonbot changed the title [DependencyInjection] Don't add .container.known_envs when empty [DependencyInjection] Don't add .container.known_envs when empty Nov 28, 2025
@GromNaN GromNaN changed the title [DependencyInjection] Don't add .container.known_envs when empty [DependencyInjection] Don't add .container.known_envs when empty in XML loader Nov 28, 2025
@GromNaN
[DependencyInjection] Don't add the .container.known_envs parameter w…
c3fa63b 
…hen empty

Other loaders does not create this parameter when there is no when@<env> key
@GromNaN GromNaN changed the title [DependencyInjection] Don't add .container.known_envs when empty in XML loader [DependencyInjection] Don't add empty .container.known_envs in XML loader Nov 28, 2025
@nicolas-grekas
Copy link
Member
nicolas-grekas commented Dec 1, 2025

Thank you @GromNaN.

@nicolas-grekas nicolas-grekas merged commit 5cf2616 into symfony:7.4 Dec 1, 2025
5 of 12 checks passed
@GromNaN GromNaN deleted the di-known-env branch December 1, 2025 20:34
GromNaN added a commit to GromNaN/symfony-config-xml-to-php that referenced this pull request Dec 2, 2025
@GromNaN
Skip .container.known_envs
66e359b 
Fix tests symfony/symfony#62558
GromNaN added a commit to GromNaN/symfony-config-xml-to-php that referenced this pull request Dec 2, 2025
@GromNaN
Skip .container.known_envs
32661cc 
Fix tests symfony/symfony#62558
@GromNaN GromNaN mentioned this pull request Dec 2, 2025
Merged
GromNaN added a commit to GromNaN/symfony-config-xml-to-php that referenced this pull request Dec 2, 2025
@GromNaN
Skip .container.known_envs (#35)
7125894 
Fix tests symfony/symfony#62558
This was referenced Dec 7, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Spomky Spomky Spomky approved these changes

Assignees

No one assigned

Labels

Bug DependencyInjection Status: Reviewed

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

4 participants

@GromNaN @nicolas-grekas @Spomky @carsonbot
0