[HttpClient] Don't reset unused clients in data collector #62415
+44
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
495c66b to
44368f4
Compare
OskarStark
approved these changes
Nov 17, 2025
nicolas-grekas
approved these changes
Nov 17, 2025
fabpot
approved these changes
Nov 20, 2025
Member
|
Thank you @HypeMC. |
This was referenced Nov 21, 2025
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data collector resets all clients on each request. When multiple scoped clients use the throttling feature, every rate limiter is reset each time, causing locks that were never used to be acquired only to be immediately released. Since most of the time only one or none of the clients is used, this behavior is unnecessary and inefficient.
This PR ensures that only clients that were actually used are reset.