[Form] Fixed the "format" option in DateType #6217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second commit should probably be done on master and it changes the behavior. |
…EFAULT_FORMAT if "widget" is not "single_text"
|
Ok, I removed the second commit now and removed the entries from the CHANGELOG. |
fabpot
added a commit
that referenced
this pull request
Dec 7, 2012
This PR was merged into the 2.1 branch. Commits ------- 6e7e08f [Form] Fixed the default value of "format" in DateType to DateType::DEFAULT_FORMAT if "widget" is not "single_text" Discussion ---------- [Form] Fixed the "format" option in DateType Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: #6141 Todo: - License of the code: MIT Documentation PR: - This PR fixes a regression introduced in #4839. To quote that PR: > This PR changes DateType and DateTimeType to support HTML5 by default when setting the option "widget" to "single_text". In reality, the "format" option now defaults to the HTML5 format always, not just when "widget" is "single_text". This is fixed here. The second commit in this PR removes special characters between select/text fields. What, with German locale, was ``` <day input>.<month input>.<year input> ``` before is now ``` <day input><month input><year input> ``` This is the way date fields are represented on the majority of websites. If you *need* separators, you can have them by setting the "format" option to a custom value: ```php $builder->add('myDate', 'date', array( 'format' => 'dd.MM.yyyy', )); ``` --------------------------------------------------------------------------- by fabpot at 2012-12-07T08:52:21Z The second commit should probably be done on master and it changes the behavior. --------------------------------------------------------------------------- by bschussek at 2012-12-07T12:23:22Z Ok, I removed the second commit now and removed the entries from the CHANGELOG.
fabpot
added a commit
that referenced
this pull request
Dec 10, 2012
This PR was merged into the 2.1 branch. Commits ------- a37e5e3 [Form] Fix const inside an anonymous function Discussion ---------- [Form] Fix const inside an anonymous function for PHP5.3 Related with the comment in #6217 --------------------------------------------------------------------------- by lsmith77 at 2012-12-10T09:14:20Z +1 .. would be good to get this merged ASAP // @fabpot @bschussek
fabpot
added a commit
that referenced
this pull request
Jan 5, 2013
This PR was merged into the master branch. Commits ------- e0b4480 [Form] Removed separator characters between choice or text fields in DateType Discussion ---------- [Form] Removed separator characters between choice or text fields in DateType Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: - License of the code: MIT Documentation PR: - This commit was originally contained in #6217 (for 2.1) but then split away for master since it changes behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #6141
Todo: -
License of the code: MIT
Documentation PR: -
This PR fixes a regression introduced in #4839. To quote that PR:
In reality, the "format" option now defaults to the HTML5 format always, not just when "widget" is "single_text". This is fixed here.