[DoctrineBridge] Fixed caching in DoctrineType when "choices" or "preferred_choices" is passed #6216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
What about a test? |
| @@ -1,6 +1,11 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| 2.1.5 | |||
There was a problem hiding this comment.
This should be removed as this is done when we release
…ferred_choices" is passed
|
Removed CHANGELOG entries and added tests. |
|
I'm not sure if @fabpot is objected to the changelog entry entirely or just the version number. What is the segfault about for PHP 5.4 in Travis? |
fabpot
added a commit
that referenced
this pull request
Dec 7, 2012
This PR was merged into the 2.1 branch. Commits ------- ca5d9ac [DoctrineBridge] Fixed caching in DoctrineType when "choices" or "preferred_choices" is passed Discussion ---------- [DoctrineBridge] Fixed caching in DoctrineType when "choices" or "preferred_choices" is passed Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: #6190 Todo: - License of the code: MIT Documentation PR: n/a --------------------------------------------------------------------------- by craue at 2012-12-06T18:31:43Z :+1: --------------------------------------------------------------------------- by lstrojny at 2012-12-06T18:35:04Z What about a test? --------------------------------------------------------------------------- by bschussek at 2012-12-07T12:39:51Z Removed CHANGELOG entries and added tests. --------------------------------------------------------------------------- by craue at 2012-12-07T13:14:02Z I'm not sure if @fabpot is objected to the changelog entry entirely or just the version number. What is the segfault about for PHP 5.4 in Travis?
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #6190
Todo: -
License of the code: MIT
Documentation PR: n/a