10000 [Config] Ensure configuration nodes do not have both `isRequired()` and `defaultValue()` by GromNaN · Pull Request #62109 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Config] Ensure configuration nodes do not have both isRequired() and defaultValue() #62109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

[Config] Ensure configuration nodes do not have both isRequired() and defaultValue() #62109

merged 1 commit into from
Oct 22, 2025

Conversation

@GromNaN
Copy link
Member
@GromNaN GromNaN commented Oct 19, 2025
Q A
Branch? 8.0
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #62076
License MIT

Convert deprecation introduced in #62090 into an exception.

@carsonbot carsonbot added this to the 8.0 milestone Oct 19, 2025
@carsonbot carsonbot changed the title [Config] Ensure configuration nodes does not have both isRequired() and defaultValue() [Config] Ensure configuration nodes does not have both isRequired() and defaultValue() Oct 19, 2025
@GromNaN GromNaN mentioned this pull request Oct 19, 2025
Merged
@GromNaN GromNaN force-pushed the config-default-required branch from fdec193 to 9860d4e Compare October 19, 2025 19:20
xabbuh
xabbuh reviewed Oct 20, 2025
View reviewed changes
xabbuh
xabbuh reviewed Oct 20, 2025
View reviewed changes
@GromNaN GromNaN force-pushed the config-default-required branch from 9860d4e to 59f69e0 Compare October 20, 2025 06:58
@GromNaN GromNaN requested a review from xabbuh October 20, 2025 06:58
@xabbuh xabbuh changed the title [Config] Ensure configuration nodes does not have both isRequired() and defaultValue() [Config] Ensure configuration nodes do not have both isRequired() and defaultValue() Oct 20, 2025
@GromNaN GromNaN merged commit d185488 into symfony:8.0 Oct 22, 2025
10 of 12 checks passed
@GromNaN GromNaN deleted the config-default-required branch October 22, 2025 09:09
@fabpot fabpot mentioned this pull request Oct 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof approved these changes

@xabbuh xabbuh xabbuh approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

@HypeMC HypeMC HypeMC approved these changes

Assignees

No one assigned

Labels

Config Feature Status: Reviewed

Projects

None yet

Milestone

8.0

Development

Successfully merging this pull request may close these issues.

6 participants

@GromNaN @stof @xabbuh @alexandre-daubois @HypeMC @carsonbot
0