[DoctrineBridge] fixed caching when EntityType is used with the "query_builder" option #6206
Conversation
…t known to Doctrine
…h the "query_builder" option
This PR was merged into the 2.1 branch. Commits ------- b604eb7 [DoctrineBridge] Improved performance of the EntityType when used with the "query_builder" option db2ee54 [DoctrineBridge] Improved exception message 99321cb [DoctrineBridge] Fixed: Exception is thrown if the entity class is not known to Doctrine Discussion ---------- [DoctrineBridge] fixed caching when EntityType is used with the "query_builder" option Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: - License of the code: MIT Documentation PR: -
| // It is important to return the same loader for identical queries, | ||
| // otherwise the caching mechanism in DoctrineType does not work | ||
| // (which expects identical loaders for the cache to work) | ||
| $hash = md5($queryBuilder->getQuery()->getDQL()); |
There was a problem hiding this comment.
This is wrong. You can have the same DQL with different parameters and different query hints
There was a problem hiding this comment.
For reference, here is the way Doctrine computes a cache key for the result cache: https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Query.php#L596
There was a problem hiding this comment.
i use the following in a subscriber which is used inside a collection (in a form):
'query_builder' => function(EntityRepository $er) use ($data) {
return $er->createQueryBuilder('pac')->where('pac.bookingAppointment = :bookingAppointment')->setParameter('bookingAppointment', $data);
}
since sf 2.1.5 is something wrong with the used closure.. when i call it twice and $data has changed, i get the same result..
There was a problem hiding this comment.
the PR has been reverted in the 2.1 branch
There was a problem hiding this comment.
ok.. sorry.. so i am looking forward to 2.1.7 :)
|
I use the entity field type to generate 2 dynamically choice list and I think I am diving into what @stof is talking about as the 2 choice list are the same which is not right... The two parameters are dynamic and the the choiceList which is generate is the same. I am completely lost... |
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -