8000 [WebProfilerBundle] ”finish” errored requests by MatTheCat · Pull Request #61960 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WebProfilerBundle] ”finish” errored requests #61960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2025
Merged

[WebProfilerBundle] ”finish” errored requests #61960

merged 1 commit into from
Oct 6, 2025

Conversation

@MatTheCat
Copy link
Contributor
@MatTheCat MatTheCat commented Oct 5, 2025
Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #61923
License MIT

If one request errors out before the toolbar is loaded, it won’t be “finished” because it won’t have a duration:

symfony/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twig

Lines 479 to 481 in 40d3c4b

if (requestStack[i].duration) {
finishAjaxRequest(i);
}

Its timer will then keep on ticking.

@carsonbot carsonbot added this to the 7.4 milestone Oct 5, 2025
@carsonbot
Copy link
carsonbot commented Oct 5, 2025

Hey!

Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "6.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@MatTheCat MatTheCat changed the base branch from 7.4 to 6.4 October 5, 2025 14:00
@MatTheCat MatTheCat mentioned this pull request Oct 5, 2025
Closed
@chalasr chalasr modified the milestones: 7.4, 6.4 Oct 5, 2025
@fabpot
Copy link
Member
fabpot commented Oct 6, 2025

Thank you @MatTheCat.

@fabpot fabpot merged commit 026f62a into symfony:6.4 Oct 6, 2025
6 of 13 checks passed
@MatTheCat MatTheCat deleted the ticket_61923 branch October 6, 2025 12:49
This was referenced Oct 28, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@HypeMC HypeMC HypeMC approved these changes

@chalasr chalasr chalasr approved these changes

Assignees

No one assigned

Labels

Bug Status: Reviewed WebProfilerBundle

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

[WebProfilerBundle] AJAX requests time keeps loading and status is not updated after a requests is canceled

5 participants

@MatTheCat @carsonbot @fabpot @HypeMC @chalasr
0