8000 [HttpFoundation] Deprecate Request::get() in favor of using properties ->attributes, query or request directly by nicolas-grekas · Pull Request #61948 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Deprecate Request::get() in favor of using properties ->attributes, query or request directly #61948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

[HttpFoundation] Deprecate Request::get() in favor of using properties ->attributes, query or request directly #61948

merged 1 commit into from
Oct 3, 2025

Conversation

@nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented Oct 3, 2025
Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? yes
Issues -
License MIT

This method is internal but used cross components (and outside of the Symfony namespace AFAIK).

But this method is dangerous, it blurs the origin of the input data.

@carsonbot carsonbot added this to the 7.4 milestone Oct 3, 2025
@nicolas-grekas nicolas-grekas merged commit 28fba80 into symfony:7.4 Oct 3, 2025
5 of 12 checks passed
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 3, 2025
Closed
@nicolas-grekas nicolas-grekas deleted the hf-req-get branch October 3, 2025 14:43
@VincentLanglet VincentLanglet mentioned this pull request Oct 5, 2025
Closed
@PierreCapel PierreCapel mentioned this pull request Oct 7, 2025
Merged
nicolas-grekas added a commit that referenced this pull request Oct 7, 2025
@nicolas-grekas
feature #61983 [HttpFoundation] Remove Request::get() (PierreCapel)
4c1b0a4 
This PR was merged into the 8.0 branch.

Discussion
----------

[HttpFoundation] Remove `Request::get()`

| Q             | A
| ------------- | ---
| Branch?       | 8.0
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT

Following #61948

Commits
-------

6f9a6a1 remove Request::get()
This was referenced Oct 27, 2025
Merged
Merged
@GromNaN GromNaN mentioned this pull request Oct 29, 2025
Merged
javiereguiluz added a commit to symfony/demo that referenced this pull request Nov 4, 2025
@javiereguiluz
bug #1615 Remove usage of deprecated Request::get() in twig templat…
9b7007f 
…e (GromNaN)

This PR was squashed before being merged into the main branch.

Discussion
----------

Remove usage of deprecated `Request::get()` in twig template

- symfony/symfony#61948

Commits
-------

4101cc4 Remove usage of deprecated `Request::get()` in twig template
70E6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof approved these changes

@chalasr chalasr chalasr approved these changes

Assignees

No one assigned

Labels

Deprecation HttpFoundation Status: Reviewed

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas @stof @chalasr @carsonbot
0