8000 [Security] Allow AuthorizationChecker::isGrantedForUser to check for guest permissions by aschempp · Pull Request #61938 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Allow AuthorizationChecker::isGrantedForUser to check for guest permissions #61938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: 7.4
Choose a base branch
from
+124 −19
Open

[Security] Allow AuthorizationChecker::isGrantedForUser to check for guest permissions #61938

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
189cb05
Allow to vote on guest user
aschempp Oct 2, 2025
b9a7c03
Add a new interface with fixed signature
aschempp Oct 20, 2025
23ed29e
CS and CHANGELOG
aschempp Oct 20, 2025
d3bb77f
Add new interface to override the method signature
aschempp Oct 24, 2025
17bc60d
Typo & Tests
aschempp Oct 24, 2025
c9e18b6
Do not overwrite OfflineTokenInterface with NullToken
aschempp Oct 24, 2025
f8254fb
Added autowiring alias
aschempp Oct 24, 2025
4b2d659
fabbot
aschempp Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Allow to vote on guest user
  • Loading branch information
@aschempp
aschempp committed Oct 27, 2025
commit 189cb05aa6917b95d7c8b03562d324bba54fd995
10 changes: 7 additions & 3 deletions src/Symfony/Component/Security/Core/Authorization/AuthorizationChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,14 @@ final public function isGranted(mixed $attribute, mixed $subject = null, ?Access
}
}

final public function isGrantedForUser(UserInterface $user, mixed $attribute, mixed $subject = null, ?AccessDecision $accessDecision = null): bool
final public function isGrantedForUser(UserInterface|null $user, mixed $attribute, mixed $subject = null, ?AccessDecision $accessDecision = null): bool
{
$token = new class($user->getRoles()) extends AbstractToken implements OfflineTokenInterface {};
$token->setUser($user);
$token = new class($user?->getRoles() ?? []) extends AbstractToken implements OfflineTokenInterface {};

if ($user) {
$token->setUser($user);
}

$this->tokenStack[] = $token;

try {
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Security/Core/Authorization/UserAuthorizationCheckerInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ interface UserAuthorizationCheckerInterface
* @param mixed $attribute A single attribute to vote on (can be of any type, string and instance of Expression are supported by the core)
* @param AccessDecision|null $accessDecision Should be used to explain the decision
*/
public function isGrantedForUser(UserInterface $user, mixed $attribute, mixed $subject = null, ?AccessDecision $accessDecision = null): bool;
public function isGrantedForUser(UserInterface|null $user, mixed $attribute, mixed $subject = null, ?AccessDecision $accessDecision = null): bool;
}
0