[Validator] Fixed form validation #6168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please implement the same change for validateValue() and squash the commits? |
Swapped arguments $groups and $subPath in ExecutionContext::validate and ExecutionContext::validateValue, so they match their interface signatures again.
|
@bschussek: done |
|
Thanks. @fabpot 👍 |
fabpot
added a commit
that referenced
this pull request
Dec 3, 2012
This PR was merged into the master branch. Commits ------- 109bb7b Fixed form validation Discussion ---------- [Validator] Fixed form validation Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: #6118 License of the code: MIT Swapped arguments $groups and $subPath in ExecutionContext::validate so it matches its interface again. Should fix #6118 --------------------------------------------------------------------------- by bschussek at 2012-12-03T12:28:42Z Could you please implement the same change for validateValue() and squash the commits? --------------------------------------------------------------------------- by jankramer at 2012-12-03T12:40:41Z @bschussek: done --------------------------------------------------------------------------- by bschussek at 2012-12-03T12:59:16Z Thanks. @fabpot 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #6118
License of the code: MIT
Swapped arguments $groups and $subPath in ExecutionContext::validate so it matches its interface again. Should fix #6118