-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Security][SecurityBundle] Dump role hierarchy as mermaid chart #61034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
damienfern
wants to merge
7
commits into
symfony:7.4
Choose a base branch
from
damienfern:feat/dump-role-chart-mermaid
base: 7.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+486
−0
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
02f2761
feat(security): add command to dump role hierarchy as a mermaid chart
damienfern dcfe489
add changelog entries
damienfern d1a118c
fix author name
damienfern c120b3c
review: use dumper direction const
damienfern bac240e
review: test the string
damienfern 8e135fe
chore: psalm fix
damienfern a61751b
review: typo fixes
damienfern File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
102 changes: 102 additions & 0 deletions
102
src/Symfony/Bundle/SecurityBundle/Command/SecurityRoleHierarchyDumpCommand.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Bundle\SecurityBundle\Command; | ||
|
||
use Symfony\Component\Console\Attribute\AsCommand; | ||
use Symfony\Component\Console\Command\Command; | ||
use Symfony\Component\Console\Completion\CompletionInput; | ||
use Symfony\Component\Console\Completion\CompletionSuggestions; | ||
use Symfony\Component\Console\Input\InputInterface; | ||
use Symfony\Component\Console\Input\InputOption; | ||
use Symfony\Component\Console\Output\OutputInterface; | ||
use Symfony\Component\Security\Core\Dumper\MermaidDumper; | ||
use Symfony\Component\Security\Core\Role\RoleHierarchyInterface; | ||
|
||
/** | ||
* Command to dump the role hierarchy as a Mermaid flowchart. | ||
* | ||
* @author Damien Fernandes <damien.fernandes24@gmail.com> | ||
*/ | ||
#[AsCommand(name: 'debug:security:role-hierarchy', description: 'Dump the role hierarchy as a Mermaid flowchart')] | ||
class SecurityRoleHierarchyDumpCommand extends Command | ||
{ | ||
public function __construct( | ||
private readonly ?RoleHierarchyInterface $roleHierarchy = null, | ||
) { | ||
parent::__construct(); | ||
} | ||
|
||
protected function configure(): void | ||
{ | ||
$this | ||
->setDefinition([ | ||
new InputOption('direction', 'd', InputOption::VALUE_REQUIRED, 'The direction of the flowchart ['.implode('|', MermaidDumper::VALID_DIRECTIONS).']', MermaidDumper::DIRECTION_TOP_TO_BOTTOM), | ||
new InputOption('format', 'f', InputOption::VALUE_REQUIRED, 'The output format', 'mermaid'), | ||
]) | ||
->setHelp(<<<'USAGE' | ||
The <info>%command.name%</info> command dumps the role hierarchy in different formats. | ||
|
||
<info>Mermaid</info>: %command.full_name% > roles.mmd | ||
<info>Mermaid with direction</info>: %command.full_name% --direction=BT > roles.mmd | ||
USAGE | ||
) | ||
; | ||
} | ||
|
||
protected function execute(InputInterface $input, OutputInterface $output): int | ||
{ | ||
if (null === $this->roleHierarchy) { | ||
$output->writeln('<comment>No role hierarchy is configured.</comment>'); | ||
return Command::SUCCESS; | ||
} | ||
|
||
$direction = $input->getOption('direction'); | ||
$format = $input->getOption('format'); | ||
|
||
if ('mermaid' !== $format) { | ||
$output->writeln('<error>Only "mermaid" format is currently supported.</error>'); | ||
return Command::FAILURE; | ||
} | ||
|
||
if (!in_array($direction, MermaidDumper::VALID_DIRECTIONS, true)) { | ||
$output->writeln('<error>Invalid direction. Available options: '.implode(', ', MermaidDumper::VALID_DIRECTIONS).'</error>'); | ||
return Command::FAILURE; | ||
} | ||
|
||
// Map console direction options to dumper constants | ||
$directionMap = [ | ||
'TB' => MermaidDumper::DIRECTION_TOP_TO_BOTTOM, | ||
'TD' => MermaidDumper::DIRECTION_TOP_DOWN, | ||
'BT' => MermaidDumper::DIRECTION_BOTTOM_TO_TOP, | ||
'RL' => MermaidDumper::DIRECTION_RIGHT_TO_LEFT, | ||
'LR' => MermaidDumper::DIRECTION_LEFT_TO_RIGHT, | ||
]; | ||
|
||
$dumper = new MermaidDumper($directionMap[$direction]); | ||
$mermaidOutput = $dumper->dump($this->roleHierarchy); | ||
|
||
$output->writeln($mermaidOutput); | ||
|
||
return Command::SUCCESS; | ||
} | ||
|
||
public function complete(CompletionInput $input, CompletionSuggestions $suggestions): void | ||
{ | ||
if ($input->mustSuggestOptionValuesFor('direction')) { | ||
$suggestions->suggestValues(MermaidDumper::VALID_DIRECTIONS); | ||
} | ||
|
||
if ($input->mustSuggestOptionValuesFor('format')) { | ||
$suggestions->suggestValues(['mermaid']); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112 changes: 112 additions & 0 deletions
112
src/Symfony/Bundle/SecurityBundle/Tests/Command/SecurityRoleHierarchyDumpCommandTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,112 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Bundle\SecurityBundle\Tests\Command; | ||
|
||
use PHPUnit\Framework\TestCase; | ||
use Symfony\Bundle\SecurityBundle\Command\SecurityRoleHierarchyDumpCommand; | ||
use Symfony\Component\Console\Application; | ||
use Symfony\Component\Console\Command\Command; | ||
use Symfony\Component\Console\Tester\CommandTester; | ||
use Symfony\Component\Security\Core\Role\RoleHierarchy; | ||
|
||
class SecurityRoleHierarchyDumpCommandTest extends TestCase | ||
{ | ||
public function testExecuteWithNoRoleHierarchy() | ||
{ | ||
$command = new SecurityRoleHierarchyDumpCommand(); | ||
$commandTester = new CommandTester($command); | ||
|
||
$exitCode = $commandTester->execute([]); | ||
|
||
$this->assertEquals(Command::SUCCESS, $exitCode); | ||
$this->assertStringContainsString('No role hierarchy is configured', $commandTester->getDisplay()); | ||
} | ||
|
||
public function testExecuteWithRoleHierarchy() | ||
{ | ||
$hierarchy = [ | ||
'ROLE_ADMIN' => ['ROLE_USER'], | ||
'ROLE_SUPER_ADMIN' => ['ROLE_ADMIN', 'ROLE_USER'], | ||
]; | ||
|
||
$roleHierarchy = new RoleHierarchy($hierarchy); | ||
$command = new SecurityRoleHierarchyDumpCommand($roleHierarchy); | ||
$commandTester = new CommandTester($command); | ||
|
||
$exitCode = $commandTester->execute([]); | ||
|
||
$this->assertEquals(Command::SUCCESS, $exitCode); | ||
$output = $commandTester->getDisplay(); | ||
$expectedOutput = <<<EXPECTED | ||
graph TB | ||
ROLE_ADMIN | ||
ROLE_USER | ||
ROLE_SUPER_ADMIN | ||
ROLE_ADMIN --> ROLE_USER | ||
ROLE_SUPER_ADMIN --> ROLE_ADMIN | ||
ROLE_SUPER_ADMIN --> ROLE_USER | ||
|
||
EXPECTED; | ||
|
||
$this->assertEquals($expectedOutput, $output); | ||
} | ||
|
||
public function testExecuteWithCustomDirection() | ||
{ | ||
$hierarchy = [ | ||
'ROLE_ADMIN' => ['ROLE_USER'], | ||
]; | ||
|
||
$roleHierarchy = new RoleHierarchy($hierarchy); | ||
$command = new SecurityRoleHierarchyDumpCommand($roleHierarchy); | ||
$commandTester = new CommandTester($command); | ||
|
||
$exitCode = $commandTester->execute(['--direction' => 'BT']); | ||
|
||
$this->assertEquals(Command::SUCCESS, $exitCode); | ||
$output = $commandTester->getDisplay(); | ||
$this->assertStringContainsString('graph BT', $output); | ||
} | ||
|
||
public function testExecuteWithInvalidDirection() | ||
{ | ||
$hierarchy = [ | ||
'ROLE_ADMIN' => ['ROLE_USER'], | ||
]; | ||
|
||
$roleHierarchy = new RoleHierarchy($hierarchy); | ||
$command = new SecurityRoleHierarchyDumpCommand($roleHierarchy); | ||
$commandTester = new CommandTester($command); | ||
|
||
$exitCode = $commandTester->execute(['--direction' => 'INVALID']); | ||
|
||
$this->assertEquals(Command::FAILURE, $exitCode); | ||
$this->assertStringContainsString('Invalid direction', $commandTester->getDisplay()); | ||
} | ||
|
||
public function testExecuteWithInvalidFormat() | ||
{ | ||
$hierarchy = [ | ||
'ROLE_ADMIN' => ['ROLE_USER'], | ||
]; | ||
|
||
$roleHierarchy = new RoleHierarchy($hierarchy); | ||
$command = new SecurityRoleHierarchyDumpCommand($roleHierarchy); | ||
$commandTester = new CommandTester($command); | ||
|
||
$exitCode = $commandTester->execute(['--format' => 'dot']); | ||
|
||
$this->assertEquals(Command::FAILURE, $exitCode); | ||
$this->assertStringContainsString('Only "mermaid" format is currently supported', $commandTester->getDisplay()); | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
129 changes: 129 additions & 0 deletions
129
src/Symfony/Component/Security/Core/Dumper/MermaidDumper.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,129 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\Security\Core\Dumper; | ||
|
||
use Symfony\Component\Security\Core\Role\RoleHierarchyInterface; | ||
|
||
/** | ||
* MermaidDumper dumps a Mermaid flowchart describing role hierarchy. | ||
* | ||
* @author Damien Fernandes <your.email@example.com> | ||
*/ | ||
class MermaidDumper | ||
{ | ||
public const DIRECTION_TOP_TO_BOTTOM = 'TB'; | ||
public const DIRECTION_TOP_DOWN = 'TD'; | ||
public const DIRECTION_BOTTOM_TO_TOP = 'BT'; | ||
public const DIRECTION_RIGHT_TO_LEFT = 'RL'; | ||
public const DIRECTION_LEFT_TO_RIGHT = 'LR'; | ||
|
||
public const VALID_DIRECTIONS = [ | ||
self::DIRECTION_TOP_TO_BOTTOM, | ||
self::DIRECTION_TOP_DOWN, | ||
self::DIRECTION_BOTTOM_TO_TOP, | ||
self::DIRECTION_RIGHT_TO_LEFT, | ||
self::DIRECTION_LEFT_TO_RIGHT, | ||
]; | ||
|
||
public function __construct( | ||
private readonly string $direction = self::DIRECTION_TOP_TO_BOTTOM, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moving |
||
) { | ||
if (!in_array($direction, self::VALID_DIRECTIONS, true)) { | ||
throw new \InvalidArgumentException(sprintf( | ||
'Direction "%s" is not valid, valid directions are: "%s".', | ||
$direction, | ||
implode('", "', self::VALID_DIRECTIONS) | ||
)); | ||
} | ||
} | ||
|
||
/** | ||
* Dumps the role hierarchy as a Mermaid flowchart. | ||
* | ||
* @param RoleHierarchyInterface $roleHierarchy The role hierarchy to dump | ||
*/ | ||
public function dump(RoleHierarchyInterface $roleHierarchy): string | ||
{ | ||
$hierarchy = $this->extractHierarchy($roleHierarchy); | ||
|
||
if ([] === $hierarchy) { | ||
return "graph {$this->direction}\n classDef default fill:#e1f5fe;"; | ||
} | ||
|
||
$output = ["graph {$this->direction}"]; | ||
$allRoles = $this->getAllRoles($hierarchy); | ||
|
||
// Add role nodes | ||
foreach ($allRoles as $role) { | ||
$output[] = $this->formatRoleNode($role); | ||
} | ||
|
||
// Add hierarchy relationships (parent -> child) | ||
foreach ($hierarchy as $parentRole => $childRoles) { | ||
foreach ($childRoles as $childRole) { | ||
$output[] = " {$this->escapeRoleName($parentRole)} --> {$this->escapeRoleName($childRole)}"; | ||
} | ||
} | ||
|
||
return implode("\n", array_filter($output)); | ||
} | ||
|
||
/** | ||
* Extracts the role hierarchy from the RoleHierarchyInterface. | ||
*/ | ||
private function extractHierarchy(RoleHierarchyInterface $roleHierarchy): array | ||
{ | ||
$reflection = new \ReflectionClass($roleHierarchy); | ||
|
||
if ($reflection->hasProperty('hierarchy')) { | ||
$hierarchyProperty = $reflection->getProperty('hierarchy'); | ||
return $hierarchyProperty->getValue($roleHierarchy); | ||
} | ||
|
||
return []; | ||
} | ||
|
||
/** | ||
* Gets all unique roles from the hierarchy. | ||
*/ | ||
private function getAllRoles(array $hierarchy): array | ||
{ | ||
$allRoles = []; | ||
|
||
foreach ($hierarchy as $parentRole => $childRoles) { | ||
$allRoles[] = $parentRole; | ||
foreach ($childRoles as $childRole) { | ||
$allRoles[] = $childRole; | ||
} | ||
} | ||
|
||
return array_unique($allRoles); | ||
} | ||
|
||
/** | ||
* Formats a role node for Mermaid. | ||
*/ | ||
private function formatRoleNode(string $role): string | ||
{ | ||
$escapedRole = $this->escapeRoleName($role); | ||
return " {$escapedRole}"; | ||
} | ||
|
||
/** | ||
* Escapes role name for use as Mermaid node ID. | ||
*/ | ||
private function escapeRoleName(string $role): ?string | ||
{ | ||
// Replace any non-alphanumeric characters with underscores | ||
return preg_replace('/[^a-zA-Z0-9_]/', '_', $role); | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.