8000 [SecurityBundle] Add missing `fixXmlConfig()` calls for OIDC token handler arrays by OskarStark · Pull Request #60996 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[SecurityBundle] Add missing fixXmlConfig() calls for OIDC token handler arrays #60996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 8.0
Choose a base branch
from
+3 −0
Open

[SecurityBundle] Add missing fixXmlConfig() calls for OIDC token handler arrays #60996

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
256bee4
[SecurityBundle] Add missing fixXmlConfig() calls for OIDC token hand…
OskarStark Jun 30, 2025
abad2b0
Update src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security…
8000 OskarStark Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[SecurityBundle] Add missing fixXmlConfig() calls for OIDC token hand… 
…ler arrays

Add fixXmlConfig() calls for 'issuers' and 'algorithms' arrays to allow
using singular XML tags that get automatically converted to plural form.
This improves XML configuration ergonomics.

As requested in PR #60929
  • Loading branch information
@OskarStark
OskarStark committed Jul 2, 2025
commit 256bee41fcda5910fd560b8d34ea96f54d1cd19b
4 changes: 3 additions & 1 deletion ...undle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcTokenHandlerFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ public function addConfiguration(NodeBuilder $node): void
{
$node
->arrayNode($this->getKey())
->fixXmlConfig($this->getKey())
->validate()
->ifTrue(static fn ($v) => !isset($v['discovery']) && !isset($v['keyset']))
->thenInvalid('You must set either "discovery" or "keyset".')
Expand Down Expand Up @@ -126,11 +125,13 @@ public function addConfiguration(NodeBuilder $node): void
->arrayNode('issuers')
->info('Issuers allowed to generate the token, for validation purpose.')
8000 ->isRequired()
->fixXmlConfig('issuer')
->scalarPrototype()->end()
->end()
->arrayNode('algorithms')
->info('Algorithms used to sign the token.')
->isRequired()
->fixXmlConfig('algorithm')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong. It needs to be set on the parent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for issuer then, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, all of them

->scalarPrototype()->end()
->end()
->scalarNode('keyset')
Expand All @@ -147,6 +148,7 @@ public function addConfiguration(NodeBuilder $node): void
->info('Algorithms used to decrypt the token.')
->isRequired()
->requiresAtLeastOneElement()
->fixXmlConfig('algorithm')
->scalarPrototype()->end()
->end()
->scalarNode('keyset')
Expand Down
Loading
0