8000 [WebProfilerBundle] Fix missing indent on non php files opended in the profiler by phcorp · Pull Request #60867 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WebProfilerBundle] Fix missing indent on non php files opended in the profiler #60867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 6.4
Choose a base branch
from
Open

[WebProfilerBundle] Fix missing indent on non php files opended in the profiler #60867

wants to merge 2 commits into from
+176 −27

Conversation

phcorp
Copy link
@phcorp phcorp commented Jun 21, 2025 •
edited
Loading
Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #60835
License MIT

This fixes non-php files indent in profiler.

Testing

Considering any project running at https://127.0.0.1:8000

Non-php file: https://127.0.0.1:8000/_profiler/open?file=config/packages/framework.yaml&line=0
PHP file: https://127.0.0.1:8000/_profiler/open?file=src/Kernel.php&line=0

@carsonbot carsonbot added this to the 7.4 milestone Jun 21, 2025
@xabbuh
Copy link
Member
xabbuh commented Jun 21, 2025

The CI failures look related.

@phcorp phcorp force-pushed the web-profiler-bundle-file-formatting branch from 5eb2fec to 5aa9f2f Compare June 21, 2025 15:52
phcorp
phcorp commented Jun 21, 2025
View reviewed changes
@phcorp phcorp force-pushed the web-profiler-bundle-file-formatting branch 4 times, most recently from 08bd097 to 2951d06 Compare June 21, 2025 16:34
nicolas-grekas
nicolas-grekas reviewed Jun 23, 2025
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Since this is a bugfix, it should target the lowest affected (and maintained) branch.
Can you please check which one it is and rebase+retarget?

@symfony symfony deleted a comment from carsonbot Jun 23, 2025
@phcorp phcorp force-pushed the web-profiler-bundle-file-formatting branch from 2951d06 to 26675ff Compare June 26, 2025 11:34
@phcorp phcorp changed the base branch from 7.4 to 6.4 June 26, 2025 11:34
@phcorp phcorp force-pushed the web-profiler-bundle-file-formatting branch from 26675ff to 2800a6a Compare June 26, 2025 11:36
@phcorp phcorp force-pushed the web-profiler-bundle-file-formatting branch from 2800a6a to 268718d Compare June 26, 2025 11:50
@phcorp
Copy link
Author
phcorp commented Jun 26, 2025

Thanks for the PR. Since this is a bugfix, it should target the lowest affected (and maintained) branch. Can you please check which one it is and rebase+retarget?

done. There are failing tests that seem unrelated to this PR and I couldn't change the milestone that was set by the automation

phcorp
phcorp commented Jun 26, 2025
View reviewed changes
src/Symfony/Bridge/Twig/Tests/Extension/CodeExtensionTest.php

public static function fileExcerptIntegrationProvider()
{
$fixturesPath = realpath(__DIR__.\DIRECTORY_SEPARATOR.'..'.\DIRECTORY_SEPARATOR.'Fixtures');
Copy link
Author
@phcorp phcorp Jun 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I'm not sure if using a relative path to access fixtures path is ok, this test CodeExtensionTest.php was moved in upper branches so it will fail if fixtures are not also moved

nicolas-grekas
nicolas-grekas approved these changes Jul 7, 2025
View reviewed changes
src/Symfony/Bridge/Twig/Tests/Extension/CodeExtensionTest.php

public static function fileExcerptIntegrationProvider()
{
$fixturesPath = realpath(__DIR__.\DIRECTORY_SEPARATOR.'..'.\DIRECTORY_SEPARATOR.'Fixtures');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$fixturesPath = realpath(__DIR__.\DIRECTORY_SEPARATOR.'..'.\DIRECTORY_SEPARATOR.'Fixtures');
$fixturesPath = \dirname(__DIR__).\DIRECTORY_SEPARATOR.'Fixtures');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

[WebProfilerBundle] Missing indent on non php files opended in the profiler
4 participants
@phcorp @xabbuh @nicolas-grekas @carsonbot
0