small fix of #5984 when the container param is not set #6071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ops, I guess it's wrong. Travis will probably confirm this in a moment. |
|
Yeah you changed the logic... |
this can happen when the config for the router is unset, but this method does not need to depend on routing. reading an unset config would raise an exception.
|
ok it's fixed. |
| $httpsPort = $this->container->getParameter('request_listener.https_port'); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Extra semicolon here... Otherwise looks good!
fabpot
added a commit
that referenced
this pull request
Nov 24, 2012
This PR was merged into the 2.0 branch. Commits ------- 29bfa13 small fix of #5984 when the container param is not set Discussion ---------- small fix of #5984 when the container param is not set this can happen when the config for the router is unset, but this method does not need to depend on routing. reading an unset config would raise an exception. --------------------------------------------------------------------------- by Tobion at 2012-11-19T20:44:31Z Ops, I guess it's wrong. Travis will probably confirm this in a moment. I will correct that. --------------------------------------------------------------------------- by flojon at 2012-11-20T22:40:07Z Yeah you changed the logic... --------------------------------------------------------------------------- by Tobion at 2012-11-21T14:42:48Z ok it's fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this can happen when the config for the router is unset, but this method does not need to depend on routing. reading an unset config would raise an exception.