10000 [travis-ci] Zend Garbage Collection only for PHP5.4 by pborreli · Pull Request #6063 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[travis-ci] Zend Garbage Collection only for PHP5.4 #6063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[travis-ci] Zend Garbage Collection only for PHP5.4 #6063

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07db298
[travis] disabled memory_limit
pborreli Nov 19, 2012
3f8665a
[travis] disabled Zend Garbage Collection only for PHP5.4
pborreli Nov 19, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[travis] disabled Zend Garbage Collection only for PHP5.4
  • Loading branch information
@pborreli
pborreli committed Nov 19, 2012
commit 3f8665a4fff31e228c89b22aa0364717929e2bc7
2 changes: 0 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,3 @@ before_script:
- COMPOSER_ROOT_VERSION=dev-master composer --prefer-source --dev install
- php src/Symfony/Component/Locale/Resources/data/build-data.php
- export USE_INTL_ICU_DATA_VERSION=1

script: phpunit -dzend.enable_gc=0
6 changes: 6 additions & 0 deletions autoload.php.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
<?php

if (version_compare(PHP_VERSION, '5.4', '>=') && gc_enabled()) {
// Disabling Zend Garbage Collection to prevent segfaults with PHP5.4+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the reference to the relevant PHP bugs, so that we can remove this when it is fixed upstream? Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'm not sure this is the right thing to do as for instance I have no problem running the test locally with PHP 5.4. Is it related to Travis somehow?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabpot but is gc enabled locally ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabpot had the same problem on multiple ubuntu vps already

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough. Can you add the references to the PHP bugs before I merge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

// https://bugs.php.net/bug.php?id=53976
gc_disable();
}

$loader = require_once __DIR__.'/vendor/autoload.php';

use Doctrine\Common\Annotations\AnnotationRegistry;
Expand Down
0