[HttpFoundation] #[IsSignatureValid] attribute
#60395
Conversation
4730169 to
c72ef83
Compare
|
|
||
| public static function getSubscribedEvents(): array | ||
| { | ||
| return [KernelEvents::CONTROLLER_ARGUMENTS => ['onKernelControllerArguments', 30]]; |
There was a problem hiding this comment.
Can you explain this 30 why this value?
There was a problem hiding this comment.
Hi @94noni , thanks for your comment! ❤️
I set the priority to 30 because I want the IsSignatureValid validation to be executed first, before IsCsrfTokenValidAttributeListener and IsGrantedAttributeListener.
But maybe I'm wrong, and one of those validations should actually run first, please let me know if the priority needs to be changed.
There was a problem hiding this comment.
i dont know on my side the proper priority but I wanted to know why you chose 30 that all
hope other review will confirm this choice :)
There was a problem hiding this comment.
IsCsrfTokenValidAttributeListener: priority 25IsGrantedAttributeListener: priority 20
30 makes sense to me if we want it run first, which I think we do.
There was a problem hiding this comment.
I too think it should run before any auth-related check that might open a session.
|
This is looking great @santysisi! I'll give it a more thorough review after 7.3 is released. |
c72ef83 to
85320cf
Compare
✨ New Feature:
#[IsSignatureValid]AttributeThis attribute simplifies signature verification by applying it declaratively at the controller level.
✅ Usage Examples
🔥 Advanced Usage (with #60102)
When throw: true is passed, exceptions are thrown instead of returning responses directly: