[JsonPath] Add utils methods first and last to JsonPath builder
#60188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JsonPath builderJsonPath builder
JsonPath builderJsonPath builder
GromNaN
approved these changes
Apr 10, 2025
| @@ -43,11 +43,21 @@ public function deepScan(): static | |||
| return new self($this->path.'..'); | |||
| } |
|
||
| public function anyIndex(): static | |||
There was a problem hiding this comment.
That's good that you renamed this method. Its name wasn't clear (to me).
mtarld
approved these changes
Apr 10, 2025
|
Thank you @alexandre-daubois. |
JsonPath builderfirst and last to JsonPath builder
This was referenced Apr 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small DX improvements that goes with #60105 and #60083.
This PR adds two new methods,
first()andlast(), added to JsonPath builder. This voluntary reminds methods from the DomCrawler component. The goal is not to add every possible method, but I thinkfirst()andlast()are common enough to be added.I also propose to rename
anyIndex()toall().