[DoctrineBridge] fix tests with Doctrine ORM 3.4+ on PHP < 8.4 #60088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d9df3d to
521ab70
Compare
|
I have pushed another commit which rewrites the test a bit to no longer mess around with Doctrine ORM internals, but provide a custom repository instead which provides the results required by the test methods. |
src/Symfony/Bridge/Doctrine/Tests/Validator/Constraints/UniqueEntityValidatorTest.php
Outdated
Show resolved
Hide resolved
Spomky
reviewed
Mar 31, 2025
src/Symfony/Bridge/Doctrine/Tests/Fixtures/SingeIntIdEntityRepository.php
Outdated
Show resolved
Hide resolved
|
|
||
| public function findByCustom() | ||
| { | ||
| return self::$result; |
There was a problem hiding this comment.
Why a static property instead of a setter?
It may lead to unreproductible tests not not correctly set between test runs right?
There was a problem hiding this comment.
That's a valid concern and @alexandre-daubois shared the same thoughts. I rewrote the code a bit to use a public instance variable instead.
521ab70 to
9be0d0a
Compare
alexandre-daubois
approved these changes
Mar 31, 2025
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution implemented in #59887 does no longer work on PHP < 8.4 with the changes made in doctrine/orm#11853.